[trello.com/c/4QaDmVkg]: BtcWalletService tests introduced #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBenua
requested review from
just-software-dev,
VeretennikovSV and
vovameister
ChrisBenua
force-pushed
the
dev/trello.com/c/4QaDmVkg
branch
from
e64d801 to
21e3727
Compare
Adamant/Modules/Wallets/Bitcoin/BitcoinKitTransactionFactoryProtocol.swift
Outdated
Show resolved
Hide resolved
just-software-dev
approved these changes
Jan 17, 2025
ChrisBenua
force-pushed
the
dev/trello.com/c/4QaDmVkg
branch
from
afc394b to
0914f69
Compare
VeretennikovSV
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BtcWalletService.createTransactiontests introduced.Disabled old tests, moved the to
DisabledTestfolder, removed them fromAdamant.TeststargetUsed only two hacks:
BtcWalletraw initializer (marked it as deprecated with message "For testing purposes only" and made it available only in DEBUG builds)BtcWalletService.setWalletForTests- method to set wallet easily for testing purposes, (marked it as deprecated with message "For testing purposes only" and made it available only in DEBUG builds)In tests I caught every custom error thrown by
createTransactionmethod, verified that parameters passed toBitcoinKit.Transaction.createTransactionsare expected.Test file is
AdamantTests/Modules/Wallets/BtcWalletServiceTests.swift